Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sct_dmri_moco - cropped vs non-cropped image #46

Open
valosekj opened this issue Jul 4, 2024 · 3 comments
Open

sct_dmri_moco - cropped vs non-cropped image #46

valosekj opened this issue Jul 4, 2024 · 3 comments

Comments

@valosekj
Copy link
Member

valosekj commented Jul 4, 2024

I'm wondering about the following thing:

  • on line 275, the DWI image is cropped (the output is "${file_dwi}"_crop.nii.gz)
  • but then, on line 277, motion correction is done on the original, non-cropped image (${file_dwi}.nii.gz)

# Crop data for faster processing
sct_crop_image -i "${file_dwi}".nii.gz -m "${file_dwi_seg}".nii.gz -dilate 15x15x0 -o "${file_dwi}"_crop.nii.gz
# Motion correction
sct_dmri_moco -i ${file_dwi}.nii.gz -bvec ${file_bvec} -x spline

Isn't file_dwi="${file_dwi}_crop" missing between lines 275 and 277?

@jcohenadad
Copy link
Member

Amazing. Good catch @valosekj and thank you for reporting it!!

jcohenadad added a commit that referenced this issue Jul 4, 2024
@jcohenadad
Copy link
Member

I fixed the issue in 84ba26f, can you make sure it works fine @Kaonashi22 and if so we can close the issue

@Kaonashi22
Copy link

I'm re-running, I'll let you know how it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants