Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GitHub action to automatically update the emoji keywords functionality #542

Closed
2 tasks done
andrewtavis opened this issue Jan 5, 2025 · 6 comments
Closed
2 tasks done
Assignees
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

As discussed in the issue planning meeting, a functionality that would be really nice to add in is a workflow that checks to see if there is new emoji data and then automatically sends a PR to update the data. Specifically we'd want the cldr-annotations-derived-full and cldr-annotations-full data that are found in src/scribe_data/unicode to be updated.

As a first step, we'd need to check around when this data is normally updated and then look into when to run the action 😊

Contribution

@axif0 could work on this as a part of Outreachy 😊

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 5, 2025
@andrewtavis
Copy link
Member Author

@axif0, do you have interest in working on this? Making a few of the aspirational issues now :)

@axif0 axif0 self-assigned this Jan 8, 2025
@andrewtavis andrewtavis moved this from Todo to In Progress in Scribe Board Jan 8, 2025
@axif0
Copy link
Collaborator

axif0 commented Jan 18, 2025

checks to see if there is new emoji data

Are we looking for the last releases of cldr-json for cldr-annotations-derived-full and cldr-annotations-full? Then like workflow checks the version if it is outdated then we can update our version?

Or we periodically run the workflow and clone the repo and just updated our src/scribe_data/unicode.

@andrewtavis
Copy link
Member Author

Would be kind of a combination of both options, @axif0 :) Similar to the Scribe Bot workflow, we'd check to see if there's a change and if there's a new update and if not then we cancel, but if there is then we update src/scribe_data/unicode with the new versions of these files 😊

@axif0
Copy link
Collaborator

axif0 commented Jan 19, 2025

Used DERIVED_LANGS, FULL_LANGS and to get the names of languages.

By passing the language one by one in the githubusercontent -

https://raw.githubusercontent.com/unicode-org/cldr-json/main/cldr-json/cldr-annotations-derived-full/annotationsDerived/$lang/annotations.json/
and
https://raw.githubusercontent.com/unicode-org/cldr-json/main/cldr-json/cldr-annotations-full/annotations/$lang/annotations.json"

Then we checked if downloaded annotations.json, is new file or modified file for PR_body. With that the PR was made,

@andrewtavis
Copy link
Member Author

Amazing progress on all of this, @axif0! 🚀

@andrewtavis
Copy link
Member Author

Closed by #551 and 042aa61 :) Changes have also already been brought in by #558 😊 Thanks, @axif0! 🛥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants