Refactor by removing existing_files check before query_result in get.py

[axif0]

Terms

• I have searched all open bug reports
• I agree to follow Scribe-Data's Code of Conduct

Behavior

Existing files check already done in line of query_result function. We can reconsider by ignoring the check before calling the query_result method. Which is more convenient.

Contribution

Happy to review a PR when one's open and support with answers to any questions! 😊

[andrewtavis]

@harikrishnatp, do you want to write in here so we can assign you? :)

[harikrishnatp]

Sure @andrewtavis, I'll take this up!

[andrewtavis]

Thanks for assigning, @axif0! Let us know if you need any support, @harikrishnatp :)

[harikrishnatp]

@andrewtavis , @axif0 I'm currently in the middle of my end-semester exams, so I might not be very active for a while. Once my exams are over, I’ll be sure to ramp up my contributions again!

[andrewtavis]

Sounds good, @harikrishnatp! Good luck with exams! 🚀

[axif0]

Here is an idea we can work on,
I found there are some duplicate existing_files checking. Like in-

For query Wikidata

• Get.py
• query_data.py

Parsing Wikidata lexeme dumps

• Parse_dump.py

I believe to clean code and more efficiency, we can extend the functionality of the check_index_exists method as such it can check if queried JSON file exists or not. And we can just call the method then.

Does this make sense? @harikrishnatp @andrewtavis

[andrewtavis]

Makes total sense to me, @axif0! Thanks for looking in to this 😊 So maybe @harikrishnatp can work on this as well and you can do the first review?