Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media library acquisition should be at install time, not build time #182

Open
cwillisf opened this issue Mar 3, 2021 · 2 comments
Open

Comments

@cwillisf
Copy link
Contributor

cwillisf commented Mar 3, 2021

Expected Behavior

All dependencies should be downloaded during npm install or npm ci.

Actual Behavior

Most dependencies are downloaded during npm install or npm ci, except for the media libraries. The media libraries are downloaded during npm run fetch which is part of the dist and distDev build commands.

Steps to Reproduce

  1. Clone this repository
  2. Run npm install or npm ci
  3. Check the static/assets/ directory
  4. Run npm run fetch or npm run dist
  5. Check the static/assets/ directory again
@cwillisf
Copy link
Contributor Author

cwillisf commented Mar 3, 2021

Fixing this could be a step toward fixing #153

@apple502j
Copy link
Contributor

Should be as easy as specifying that as postinstall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants