Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to deploy only once instead of three times #24

Merged
merged 1 commit into from
Nov 7, 2018

Conversation

fsih
Copy link

@fsih fsih commented Nov 5, 2018

Attempting to fix #21

@fsih fsih added this to the November 2018 milestone Nov 5, 2018
@fsih fsih requested a review from rschamp November 5, 2018 20:25
Copy link

@rschamp rschamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! FYI other ways to solve this:

  • travis-deploy-only-once (I just discovered this, it looks like an improvement over travis-after-all)
  • You could convert this config to use Travis build stages, where you would run the tests in 3 parallel jobs, and then just run one job in a second "Release" stage. You would specify the environment for that in exactly the same way as you're doing here to ensure only one job is created.

@rschamp rschamp assigned fsih and unassigned rschamp Nov 7, 2018
@fsih fsih merged commit 072bdc4 into scratchfoundation:develop Nov 7, 2018
@fsih fsih deleted the fixDeploy branch November 7, 2018 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We're deploying 3 times per time
2 participants