Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Unequippable weapons for specific banks showing as equippable. #6398

Open
jlberman opened this issue Oct 16, 2024 · 7 comments
Open

Bug: Unequippable weapons for specific banks showing as equippable. #6398

jlberman opened this issue Oct 16, 2024 · 7 comments

Comments

@jlberman
Copy link

In ships.tbl, there's only one weapon that can be equipped in the first bank of this ship.

image

Click that bank in the weapon loadout room, and the loadout room shows that you can equip those weapons in that bank.

image

But when you try to drag an invalid weapon into that bank, it gives you an error.

screen0249

It should grey out invalid banks in the UI when you can't load a particular weapon into a particular bank.

Note to @Goober5000 : This can be replicated in Inferno M14.

@EatThePath
Copy link
Contributor

Unless this situation plays out differently in a past version of FSO, I think this is not really a bug. If memory serves, outside of some bomb slots retail doesn't do a lot with having different compatibility for different banks, so the UI just isn't designed to react like that.
I'm willing to be wrong if you can point to a scenario where it does re-actively grey out weapons based on bank selection, or did in a past version.

@jlberman
Copy link
Author

Oh, OK. So this is really a feature request, then?

@EatThePath
Copy link
Contributor

Oh, OK. So this is really a feature request, then?

Yes, probably. Though I think it's also a feature mods can probably implement with Lua these days, too.

@MjnMixael
Copy link
Contributor

This does work in SCPUI out of the box.

@wookieejedi
Copy link
Member

Interesting, if manually created icons are used instead (such as eff image sequences for the icons) then they properly show as greyed out. I wonder if this feature just never made it over to the generated icons feature?

@Goober5000
Copy link
Contributor

Hmm. It's entirely possible that updates were made to one part of the UI but not another part. There have been many updates over the years, and it's not uncommon for an upgrade in one part of the code to miss a very similar case elsewhere in the code.

@jlberman
Copy link
Author

Yeah, because in retail it does grey out those things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants