Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FRED bug: $Display Name deleted on mission save #6383

Open
Achille44 opened this issue Oct 6, 2024 · 3 comments
Open

FRED bug: $Display Name deleted on mission save #6383

Achille44 opened this issue Oct 6, 2024 · 3 comments
Labels
fred A feature or issue related to the FReespace EDitor (FRED) not a bug Working as intended... except what was intended is now insufficient or wrong. Requested by Active Mod A feature request that has been requested by a mod that is actively in development.

Comments

@Achille44
Copy link

On mission files, $Display Name for ships is required for translations, but FRED deletes it when saving the file.

Steps to reproduce:

  1. Open any mission file with a text editor and add a $Display Name below any ship:
$Name: Beta 1		;! Object #0
$Display Name: XSTR("Beta 1", -1)
  1. Open the mission with FRED, and just save. Now the $Display Name is gone.
@MjnMixael MjnMixael added bug An issue from unintended consequences fred A feature or issue related to the FReespace EDitor (FRED) Requested by Active Mod A feature request that has been requested by a mod that is actively in development. labels Oct 6, 2024
@Goober5000
Copy link
Contributor

This is working as designed. The removal of $Display Name, in cases where the display name and the actual name are identical, is required for other reasons.

Translation support is a legitimate reason to keep the $Display Name in place though, so this will require some thought.

@Goober5000 Goober5000 added not a bug Working as intended... except what was intended is now insufficient or wrong. and removed bug An issue from unintended consequences labels Oct 6, 2024
@naomimyselfandi
Copy link
Contributor

What other reasons is it required for?

@Goober5000
Copy link
Contributor

I don't remember exactly, and #2710 doesn't completely describe the rationale. I'll have to try to reconstruct the thought process. I do remember that the current display-name behavior was the result of extensive testing and juggling several requirements among several mods. I'm fairly sure Series Resurrecta was one, and I think NeonShivan's mod was another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fred A feature or issue related to the FReespace EDitor (FRED) not a bug Working as intended... except what was intended is now insufficient or wrong. Requested by Active Mod A feature request that has been requested by a mod that is actively in development.
Projects
None yet
Development

No branches or pull requests

4 participants