Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly instrument streaming responses #626

Open
adamchainz opened this issue Feb 10, 2021 · 0 comments
Open

Correctly instrument streaming responses #626

adamchainz opened this issue Feb 10, 2021 · 0 comments

Comments

@adamchainz
Copy link
Contributor

Django (StreamingHttpResponse) and other frameworks support streaming HTTP responses. Currently our middleware-based instrumentation will not capture all the time sent streaming the response out, but instead prematurely close the TrackedRequest.

To correctly capture such responses we'd want to detect them and change behaviour to only close the TrackedRequest once their iteration has completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant