Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate support for FastAPI and FastAPI SQL Alchemy #600

Open
jrothrock opened this issue Jan 28, 2021 · 1 comment
Open

Investigate support for FastAPI and FastAPI SQL Alchemy #600

jrothrock opened this issue Jan 28, 2021 · 1 comment

Comments

@jrothrock
Copy link
Contributor

From initial appearance, it looks like our Starlette integration works pretty well for FastAPI, but it doesn't appear that SQL timings are being collected when using the FastAPI SQL Alchemy library. Everything gets aggregated under 'View'

@adamchainz
Copy link
Contributor

We don't collect any SQL timings in the async world. It's a bit harder and from what I recall the core agent and Python internals' data models aren't ready for parallel spans, something that's pretty much guaranteed with async apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants