Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing information #589

Open
wagdez opened this issue Oct 19, 2020 · 1 comment
Open

Add typing information #589

wagdez opened this issue Oct 19, 2020 · 1 comment

Comments

@wagdez
Copy link

wagdez commented Oct 19, 2020

We currently ignore typing of scout_apm in our project
import scout_apm.api # type: ignore
it would be nice to have typing information

@adamchainz
Copy link
Contributor

Hi @wagdez !

I agree, it would be nice to ship type hints for the public API. We're a little constrained on that since we still support Python 2.7, since so many customers use it. Although it's possible to ship type stub files alongside Python 2.7 code, there's at least the unicode/str mess to address.

To be honest we'd need to do some more research to figure out the approach there - personally I've only worked with type hints in application code bases, from Python 3.7+. If you can point to any resources on maintaining type hints on Python 2.7+ projects that'd be useful.

Thanks,

Adam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants