Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support aioredis & aioelasticsearch #534

Open
yoav-orca opened this issue Jul 18, 2020 · 1 comment
Open

Support aioredis & aioelasticsearch #534

yoav-orca opened this issue Jul 18, 2020 · 1 comment

Comments

@yoav-orca
Copy link

Hi, we love using scout but we are missing the async support in python, specifically for Redis (aioredis) & ElasticSearch (aioelasticsearch), are there any plans to support them? Will you accept PRs for adding support for them?

@adamchainz
Copy link
Contributor

Hi @yoav-orca

Thanks for the support. We don't have any specific issues tracking aioredis or aioelasticsearch. We'd love to expand support for them though.

If you're interested in instrumenting them you can probably implement something within your own project or a fork of scout-apm. The instruments submodule contains our current instrumentation of libraries: https://github.com/scoutapp/scout_apm_python/tree/master/src/scout_apm/instruments . The main difficulty you'll find with making an implementation within scout-apm is keeping all async code in the scout_apm.async_ module because we support Python 2 still. However you look into adding instrumentation we'd love to see it and will consider PR's.

Thanks,

Adam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants