Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move out Passwords and other ENV variables of Deployment.yamls. #926

Open
agentmilindu opened this issue Aug 3, 2020 · 0 comments
Open

Move out Passwords and other ENV variables of Deployment.yamls. #926

agentmilindu opened this issue Aug 3, 2020 · 0 comments

Comments

@agentmilindu
Copy link
Collaborator

Bassa/scripts/kubernetes/manifests/api_and_aria2c/deployment.yml

Line 30 in b7668b9

value: 'bassa@1234'

https://github.com/scorelab/Bassa/pull/828/files#diff-16a3a975467f18ae05c8a74a608e5ad0R24-R30

env:
        - name: BASSA_DB_NAME
          value: 'Bassa'
        - name: BASSA_DB_USERNAME
          value: 'bassa'
        - name: BASSA_DB_PASSWORD
          value: 'bassa@1234'

We are using these in multiple pods, better we move them out and especially the secrets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@agentmilindu