You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now that we have more people actively involved, let's start using pull requests for all code changes.
I think I'd also like to switch to using merge commits instead of rebasing, but extra/make-changelog.py likely wouldn't do a too good job with that. We should probably switch also to some other tooling for generating the changelogs, I bet a bunch of ready made applicable ones exist as/if we're moving towards using conventional commits commit messages (should document that in CONTRIBUTING.md BTW, and likely add a commitlint pre-commit check).
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Now that we have more people actively involved, let's start using pull requests for all code changes.
I think I'd also like to switch to using merge commits instead of rebasing, but extra/make-changelog.py likely wouldn't do a too good job with that. We should probably switch also to some other tooling for generating the changelogs, I bet a bunch of ready made applicable ones exist as/if we're moving towards using conventional commits commit messages (should document that in CONTRIBUTING.md BTW, and likely add a commitlint pre-commit check).
Thoughts?
Beta Was this translation helpful? Give feedback.
All reactions