diff --git a/docs/release-notes/v0.7.3.rst b/docs/release-notes/v0.7.3.rst index 4056983fa7..e23190b554 100644 --- a/docs/release-notes/v0.7.3.rst +++ b/docs/release-notes/v0.7.3.rst @@ -15,12 +15,16 @@ Fixes (PRs :pr:`2277`, :pr:`2278`) The fixed bug was subtle and only occurred for specific configurations of - settings and arguments. - To determine if you might have been affected by it see if you used a setup - like the following in any part of your code + settings and arguments where ``do_grad=False`` was used (either explicitly + by provided kwarg or implicitly through defaults). + To determine if you might have been affected by it, check your code for + setups like the following. .. code:: python + # Bug is backend independent. JAX is selected as an example where + # do_grad=False might be selected in response to the backend's value of + # pyhf.tensorlib.default_do_grad being True. pyhf.set_backend("jax", pyhf.optimize.minuit_optimizer(strategy=0)) ... @@ -43,6 +47,14 @@ Fixes ) data = [51, 48] + model.config.auxdata + # passing with strategy kwarg explicitly given + fit_result, opt_result = pyhf.infer.mle.fit( + data, model, return_result_obj=True, do_grad=False, strategy=0 + ) + minuit_strategy = opt_result.minuit.strategy.strategy + print(f"# Minuit minimization strategy: {minuit_strategy}") + assert minuit_strategy == 0 + # strategy kwarg not given fit_result, opt_result = pyhf.infer.mle.fit( data, model, return_result_obj=True, do_grad=False