Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pack() functions to accept strings as input for as_sources and as_targets args #80

Open
YanisLalou opened this issue Feb 8, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@YanisLalou
Copy link
Collaborator

Currently, every DAdataset packing function is only compatible with List[str] for the as_sources and as_targets arguments. However, in cases where we have only one target and one source, it would be simpler to use a single string instead of a list of strings.
OR, the use of strings altogether could be prohibited.
Right now, when we provide a string instead of a list, the packing functions iterate over the string, letter by letter, eventually raising a KeyError exception."

@YanisLalou YanisLalou added the good first issue Good for newcomers label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant