Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup DomainAwareDataset API #15

Open
kachayev opened this issue Nov 21, 2023 · 0 comments
Open

Cleanup DomainAwareDataset API #15

kachayev opened this issue Nov 21, 2023 · 0 comments
Labels
domain-aware api high complexity

Comments

@kachayev
Copy link
Collaborator

  • review methods and naming convention, make sure all methods are necessary
  • write docstrings
  • test cases, specifically to cover the functionality of adding new domains, getting domain and selecting multiple domains
  • test cases to cover failure modes, like overlapping names
tgnassou added a commit that referenced this issue Nov 22, 2023
@tgnassou
Merge pull request #15 from tgnassou/subspace_dataset
72377b7 
add linear subspace dataset toy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain-aware api high complexity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kachayev