Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken handling of single-line messages with a tag block #203

Open
hogend opened this issue May 28, 2020 · 0 comments
Open

Broken handling of single-line messages with a tag block #203

hogend opened this issue May 28, 2020 · 0 comments

Comments

@hogend
Copy link

hogend commented May 28, 2020

Single-line messages are never parsed because of

tag_block.py: 147:
if sentence_num == 1:
self.groups[group_id] = {
'line_nums': [self.line_num],
'lines': [line],
'matches': [match],
'times': [time],
}
return

i.e. sentence_num == 1 always returns and the subsequent decoding code is unreachable.

Suggested fix:
if sentence_num == 1:
self.groups[group_id] = {
'line_nums': [],
'lines': [],
'matches': [],
'times': [],
}

then the data will be appended and, if sentence_num == sentence_total, decoded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant