Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One possible fix (and note, switching to argument defaults instead of hard links makes it compatible with the Wayback Machine for getting archival data): #20

Open
scarnecchia opened this issue Apr 21, 2022 · 1 comment

Comments

@scarnecchia
Copy link
Owner

scarnecchia commented Apr 21, 2022

Creating a new issue for this idea by @leedrake5, as it offers a more flexible option for coding the URLs.

One possible fix (and note, switching to argument defaults instead of hard links makes it compatible with the Wayback Machine for getting archival data):

russia_materiel <-
  get_data(
    russia_link,
    "article"
  ) %>%
  rvest::html_elements("li")
  
  ukraine_materiel <-
    get_data(
    ukraine_link,
      "article"
    ) %>%
    rvest::html_elements("li")
    
    materiel <- c(russia_materiel, ukraine_materiel)

Note that this requires the 'do' package to concat xml node sets.

Originally posted by @leedrake5 in #18 (comment)

@leedrake5
Copy link

Minor change, add the following as default arguments to the function:

russia_link="https://www.oryxspioenkop.com/2022/02/attack-on-europe-documenting-equipment.html", ukraine_link="https://www.oryxspioenkop.com/2022/02/attack-on-europe-documenting-ukrainian.html"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants