Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

munit has gotten perceivably slower when bumping v0.7.29 => v1.0.0 #787

Open
Gedochao opened this issue May 24, 2024 · 0 comments
Open

munit has gotten perceivably slower when bumping v0.7.29 => v1.0.0 #787

Gedochao opened this issue May 24, 2024 · 0 comments

Comments

@Gedochao
Copy link

Gedochao commented May 24, 2024

Version
Noticed when bumping munit v0.7.29 => v1.0.0

Replication
Haven't got the time to minimise this, but here's what I got:

./mill -i 'build-module[].test' 'scala.build.tests.BuildTests*.compile 12k sources for Scala*'
  • the tests fail on the CI (GH actions standard runner) and a subset of them also fail on my local machine with a timeout
  • what fixes it is increasing munitTimeout from the default 30s to 120s: VirtusLab/scala-cli@d8b5b49

The test in question is here:

Context
I'll still update Scala CLI to munit v1.0.0, as I need the Scala Native 0.5.x support, so can't afford to stay on v0.7.29. Still, I wonder if this performance drop is expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant