Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for beta feature Concurrency #79

Open
jlprat opened this issue Aug 16, 2021 · 3 comments
Open

Support for beta feature Concurrency #79

jlprat opened this issue Aug 16, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@jlprat
Copy link

jlprat commented Aug 16, 2021

GitHub workflows have now a feature in beta, concurrency. One can read more in here: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#concurrency

The feature enables to stop an already running workflow when a new one is enqueued. Enabling this would save lots of time on CI servers for jobs that are already obsolete.
To configure it, this should be added to the continuous integration yml file:

concurrency:
  group: ci-${{ github.ref }}
  cancel-in-progress: true

@djspiewak Would you consider adding this feature even though is still in Beta on GitHub side? I would be willing to contribute it.

@djspiewak
Copy link
Collaborator

@jlprat Finally got around to this! This looks really awesome honestly, and feels like something that should definitely be well integrated into this plugin. Would love to have it as a feature!

In particular, I think we should ensure that it's configurable, but the default should be to group based on Pull Request specifier (I believe that is what github.ref covers) or upstream branch if not on a PR.

@djspiewak djspiewak added the enhancement New feature or request label Nov 29, 2021
@pjfanning
Copy link
Contributor

@mdedetrich this is useful. sbt-typelevel's equivalent plugin to this supports it.

@mdedetrich
Copy link
Contributor

There are plans to upstream this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants