WEA Tool self containment

[VorTechnix]

Problems:

• Move over to wea_c.pos completely -- Some tools (specifically Cloudwand) still use wea.selection
• Multiwand still uses wea.farwand.do_raycast -- needs to be moved over to wea_t.do_raycast like the Cloudwand uses

  Minetest-WorldEditAdditions/worldeditadditions_tools/items/multiwand.lua

  Line 47 in d638a34

  local looking_pos, node_id = wea.farwand.do_raycast(player)

• Minimize the number of files that need local wea = worldeditadditions and if possible remove dependency on WEA altogether so that WEA Tool only needs WEA Core as a dependency
• I will do work after PR Farwand refactor #117 is completed to remove the WE dependency which is mostly just calls to WE.player_notify which I already have plans to replace Implement player notification in WEA core #116

[sbrl]

Erm I don't see wea_t depending on main wea as a problem - in fact I have an idea in my head to implement an advanced tool that can temporarily take over your hotbar that will depend on wea

Similarly the raycasting function really should live in worldeditadditions_core and not the far wands mod I think, as it could be useful to other functions

but the rest looks good! thanks for doing this, 'cause it's really needed

[sbrl]

Oh wait, I see why we have do_raycast in wea_t

ignore me on that point

[VorTechnix]

Erm I don't see wea_t depending on main wea as a problem - in fact I have an idea in my head to implement an advanced tool that can temporarily take over your hotbar that will depend on wea

Oh, ok. I just found that very few things actually were depending on WEA so I figured we could eliminate those but if you're planning to expand that's fine.

Similarly the raycasting function really should live in worldeditadditions_core and not the far wands mod I think, as it could be useful to other functions

Right now we have 3 raycast functions: wea.farwand.do_raycast, wea_core.do_raycast and wea_tool.do_raycast which is a wrapper for wea_core.do_raycast. At least one of those needs to go!

[sbrl]

Right
That is a problem
Okay

In your branch farwand-refactor I see:

• worldeditadditions_tools.do_raycast - wrapper that manages application of settings
• worldeditadditions_core.raycast - core raycasting functionality

....but I don't see wea.farwand.do_raycast?

[VorTechnix]

Minetest-WorldEditAdditions/worldeditadditions_farwand/lib/multiwand.lua

Line 46 in e89d610

local looking_pos, node_id = wea.farwand.do_raycast(player)

[sbrl]

I still can't find that function definition wow

How does it even still work?

[sbrl]

Got it

On dev:

Minetest-WorldEditAdditions/worldeditadditions_farwand/init.lua

Line 1 in 30e1549

worldeditadditions.farwand = {

note that originally the main namespace is registered under worldeditadditions as wea.farwand

Hence the wea.farwand.do_raycast call in your branch needs to read wea_t.raycast

[sbrl]

Pushed a commit to tidy this whole situation w/compat pos.lua calls up

b57b3e8..90f9723