Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in documentation #294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

favna
Copy link
Member

@favna favna commented Jan 24, 2025

Fixes #292

Fix the broken relative link in the documentation.

  • Update the link "Application Command Registry" in docs/Guide/commands/application-commands/what-are-application-commands.mdx to use the correct relative path.
  • Ensure the link redirects to docs/Guide/commands/application-commands/application-command-registry/what-is-it.

For more details, open the Copilot Workspace session.

Fixes #292

Fix the broken relative link in the documentation.

* Update the link "Application Command Registry" in `docs/Guide/commands/application-commands/what-are-application-commands.mdx` to use the correct relative path.
* Ensure the link redirects to `docs/Guide/commands/application-commands/application-command-registry/what-is-it`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/sapphiredev/website/issues/292?shareId=XXXX-XXXX-XXXX-XXXX).
Copy link

cloudflare-workers-and-pages bot commented Jan 24, 2025

Deploying website with  Cloudflare Pages  Cloudflare Pages

Latest commit: bf779d9
Status: ✅  Deploy successful!
Preview URL: https://2d38be99.website-9yz.pages.dev
Branch Preview URL: https://favna-fix-broken-links.website-9yz.pages.dev

View logs

Copy link
Contributor

@GeniusTimo GeniusTimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have found the bug that is causing this problem as I was trying the updated version. Visiting the site directly adds an / at the end of the path if there isn't one already. If I interact with the sidebar the site navigates me to to the path without the / at the end. Therefore relative links get confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Broken links depending on the window history
4 participants