Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMouseWheelZoomXYEventHandler : I can not commit (403 Forbidden) #265

Open
GoogleCodeExporter opened this issue Mar 14, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

Hello,

I coded a new class but can not commit it. (403 Forbidden)
Please, would you like to commit it to the SVN.

Thanks,
Nico

Here is the commit message :

 * This commit bring a new class, the PMouseWheelZoomXYEventHandler which is a evolved zoom event handler.
   The default behavior is the same as the existing PMouseWheelZoomEventHandler but 2 other behaviors are available :
    -> If the user maintains the "SHIFT" key during mouse wheel motion, only the X axis will be rescaled.
    -> If the user maintains the "ALT" key during mouse wheel motion, only the Y axis will be rescaled.
    NB : With the default behavior, the zoom will be applied on X and Y axis (as PMouseWheelZoomEventHandler).

 * Somes changes are necessary in the following classes :
    1) PCamera
       --> adding the method 
           public void scaleViewAboutPoint(final double scaleX, final double scaleY, final double x, final double y)
       --> updating the method
           public void scaleViewAboutPoint(final double scale, final double x, final double y)
    2) PMouseWheelZoomEventHandler need to be inheritable.
       --> removing the "final class"
       --> scaleFactor is now protected
       --> private Point2D getViewAboutPoint(final PInputEvent event) is now protected
    3) PAffineTransform
       --> the method 
           public void scaleAboutPoint(final double scaleX, final double scaleY, final double x, final double y)
           has been added.
       --> the method
           public void scaleAboutPoint(final double scale, final double x, final double y)
           has been modified.
    Please note, that all these changes are fully compatible with the previous version.

Original issue reported on code.google.com by [email protected] on 8 Mar 2015 at 12:57

Attachments:

@GoogleCodeExporter
Copy link
Author

Hello Nico,

Thanks for the submission.  Sorry about the 403, the way Google Code is set up 
is to only allow project members to have commit access.  I'll review these 
changes.

I assume you would like these to apply to svn trunk/version 3.x?


Original comment by [email protected] on 9 Mar 2015 at 6:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant