Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider building against Java versions newer than 21 #193

Closed
nelind3 opened this issue Sep 5, 2024 · 3 comments
Closed

Reconsider building against Java versions newer than 21 #193

nelind3 opened this issue Sep 5, 2024 · 3 comments

Comments

@nelind3
Copy link
Contributor

nelind3 commented Sep 5, 2024

I meant to try and catch this on the 1.21 PR but didn't manage to do so before it got merged so i figured making an issue would be appropriate.

As we all know one of the really major changes in 1.20.5 was the update from Java 17 to Java 21 as such mods built for anything post 1.20.5 will have to use Java 21 or newer. However realistically most people will run servers and the game with Java 21. The community at large expects everyone to run the game and build code against the minimum required Java version. Many setups for running the game (including the official launcher or the most used docker image for Minecraft server software) don't include built in functionality for running the game with any other version than the minimum required version (like the official launcher) or need specific support for it which is very low priority since it's generally not needed (like the docker image).

In #192 the build.gradle compatibility version was set to Java 22 and the CI configuration was changed to build released against Java 23. Since the JVM won't (for good reason) load classes that are built against a newer Java version doing this would effectively force every consumer of Taterzens to run their game on Java 23 or later. This would exclude many people from running or using Taterzens either because they use the vanilla launcher or because they for some other reason can't (or won't) use anything other than Java 21. I'd hate to see Taterzens not get used (and not be able to use it) simply because it's built against an unusual Java version.

Other than that I'd like you thank you all for the absolutely amazing work that you all have put into this project!! It's amazing to see projects like this that make fabric based servers a great option to choose!!

@samolego
Copy link
Owner

samolego commented Sep 6, 2024

Hi! Thanks for the explanation and suggestion! If you have any spare time, feel free to PR it 😉

@nelind3
Copy link
Contributor Author

nelind3 commented Sep 7, 2024

Fixed by #194

@nelind3 nelind3 closed this as completed Sep 7, 2024
@samolego
Copy link
Owner

samolego commented Sep 7, 2024

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants