patchItemSave clears all inventories on world save

[Ampflower]

Description

The configuration, patchItemSave, clears all items from the world on either manual save (i.e. pausing the world on the client, or running /save-all on the server), or periodically by the auto-save timer.

Steps to reproduce.

1. /save-all, pause the game (client only), or wait for the auto-save timer. This may also apply when you stop and start the world on the client due to the potential of two save rounds occurring, one for pause, and one for server shutdown.
2. Notice how all items and inventories that stayed after the save round has disappeared, or has been emptied.

Cause

Line 26, this.setCount(0)

GolfIV/src/main/java/org/samo_lego/golfiv/mixin/duplication/ItemStackMixin_SavePatch.java

Lines 22 to 37 in 354e9bf

	@Inject(method = "writeNbt(Lnet/minecraft/nbt/NbtCompound;)Lnet/minecraft/nbt/NbtCompound;", at = @At("HEAD"), cancellable = true)
	private void writeStack(NbtCompound nbt, CallbackInfoReturnable<NbtCompound> cir) {
	if(golfConfig.duplication.patchItemSave) {
	ItemStack copy = ((ItemStack) (Object) this).copy();
	this.setCount(0);
	Identifier identifier = Registry.ITEM.getId(copy.getItem());
	nbt.putString("id", identifier.toString());
	nbt.putByte("Count", (byte)copy.getCount());
	if (copy.getNbt() != null) {
	nbt.put("tag", copy.getNbt().copy());
	}
	cir.setReturnValue(nbt);
	}
	}

Current Workarounds

Disable patchItemSave by setting the value in the config to false.

Possible fixes

• Call the alternative save function when the inventory is known to be destroyed right after. This would include going through a portal or going into unloaded chunks.

[samolego]

I'm pretty sure I meant to implement this as if inventory would be destroyed afterwards, as you've mentioned in Possible fixes. I'll release a version without this as it's clearly not the intended thing