Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id is missing from Log typing in documentation #128

Open
kgrhartlage opened this issue Sep 28, 2023 · 0 comments
Open

id is missing from Log typing in documentation #128

kgrhartlage opened this issue Sep 28, 2023 · 0 comments

Comments

@kgrhartlage
Copy link

The current documentation reads:

type Logs = Log[]

interface Log {
  // The log method
  method: Methods
  // The arguments passed to console API
  data: any[]
}

However, id seems to be supported and is used for the list key prop. This helped me resolve a bug in my application where we start to mutate the logs array once a max length is reached, while new logs are still coming in.

If desired, I can open a PR to update the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant