suggested AdminIdentity user config improvements

[noelmcloughlin]

These are PR comments from (merged) #142
It would be great if someone could follow up & close this issue when done.

comment

users_{{ users.polkit_dir }}/99salt-users-formula.conf:
file.managed:
@EvaSDK
EvaSDK on 5 Jul 2018
While salt.states.ini_manage has some issues, maybe it would be better to use it here anyway?

comment

{% if polkitusers.update({'value': polkitusers.value + 'unix-user:' + name + ';'}) %}
@EvaSDK
EvaSDK on 5 Jul 2018
this statement-less if makes me think you want to use do.

comment

noelmcloughlin on 12 Jun 2018 Member
Should we force users.polkit or simply document in README?

@0xf10e
0xf10e on 14 Jun 2018 Member
I don't think we should force this on everyone as not every OS supported by this formula includes polkit in its default installation.
Maybe have something like polkit_by_default in map.jinja and have it overwritten with something in pillar[users-formula]?

@noelmcloughlin
noelmcloughlin on 14 Jun 2018 Member
Hmm I'm not familiar with polkit so agree @0xf10e this could be pillar (default False). @IMBArator Could you update and I'll be happy to review/approve. thanks!!