Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkOrder is on by default in CLI but not in lib #1269

Open
nlochschmidt opened this issue Sep 12, 2024 · 0 comments
Open

checkOrder is on by default in CLI but not in lib #1269

nlochschmidt opened this issue Sep 12, 2024 · 0 comments
Labels
s: pending triage Pending Triage

Comments

@nlochschmidt
Copy link

Describe the bug

Based on the CLI documentation I assumed the default for checkOrder would be true when running node-pg-migrate as a library. However that documentation is only about the CLI and in the case of the Programmatic API, the default is undefined which makes checkOrder false. To be fair, the Programmatic API documentation doesn't make any claims about default values so this can be considered a user error as well.

Steps to reproduce

  1. Create a migration
  2. Run the migration
  3. Create a new migration with an older timestamp
  4. Run it with the CLI and see it fail
  5. Run it with the Programmatic API and see it getting applied out of order

Logs

No response

System Info

Node: 20.17.0
node-pg-migrate: 6.2.2 (but seems to be the same in 7.x)

Used Module System

esm

@nlochschmidt nlochschmidt added the s: pending triage Pending Triage label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: pending triage Pending Triage
Projects
None yet
Development

No branches or pull requests

1 participant