Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Fetch API #358

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Add support for Fetch API #358

wants to merge 21 commits into from

Conversation

witoszekdev
Copy link
Member

@witoszekdev witoszekdev commented Mar 8, 2024 •
edited
Loading

This PR adds experimental support for Next.js Edge Runtime + other runtimes, which uses Request and Response from Web API

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: d5e8785

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@saleor/app-sdk Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@witoszekdev witoszekdev added the enhancement New feature or request label Mar 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20240308095843.

Install it with:

pnpm add @saleor/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20240308100223.

Install it with:

pnpm add @saleor/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20240308101124.

Install it with:

pnpm add @saleor/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20240308115556.

Install it with:

pnpm add @saleor/[email protected]

typeofweb
typeofweb reviewed Mar 11, 2024
View reviewed changes
src/fetch-middleware/with-method.ts Outdated Show resolved Hide resolved
src/fetch-middleware/with-saleor-domain-present.ts

const debug = createFetchMiddlewareDebug("withSaleorDomainPresent");

export const withSaleorDomainPresent: FetchMiddleware = (handler) => async (request) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep on using it? I believe domain is soft-deprecated and we should switch to saleorApiUrl instead

@witoszekdev witoszekdev changed the title Add support for Next.js Edge Runtime Add support for Fetch API Dec 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20250102142633.

Install it with:

pnpm add @saleor/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20250102143707.

Install it with:

pnpm add @saleor/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20250102154407.

Install it with:

pnpm add @saleor/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20250103130801.

Install it with:

pnpm add @saleor/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20250109150409.

Install it with:

pnpm add @saleor/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

Package Line Rate Branch Rate Complexity Health
src 74% 93% 0 ➖
src.APL 85% 85% 0 ✔
src.APL.saleor-cloud 75% 86% 0 ✔
src.APL.vercel-kv 54% 69% 0 ➖
src.app-bridge 88% 86% 0 ✔
src.handlers.next 88% 79% 0 ✔
src.handlers.next.saleor-webhooks 91% 78% 0 ✔
src.handlers.shared 100% 100% 0 ✔
src.middleware 60% 97% 0 ➖
src.settings-manager 96% 89% 0 ✔
src.test-utils 100% 90% 0 ✔
src.util 82% 100% 0 ✔
Summary 82% (3775 / 4576) 87% (453 / 523) 0 ✔

@github-actions GitHub Actions
Copy link
Contributor

Released snapshot build with @dev tag in npm with version: 0.0.0-pr-20250110173426.

Install it with:

pnpm add @saleor/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typeofweb typeofweb typeofweb left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@witoszekdev witoszekdev

Labels
enhancement New feature or request release dev tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witoszekdev @typeofweb