-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making Parsed Source Code Data Available Externally #314
Comments
@carlosparadis part II |
@daomcgill For this one I would consider making two execs, one that annotates, and the other that can query the file. Annotating can take a long time depending on the size of the project, hence the split. Otherwise, I think this is good! We can take another pass once #313 is done. Thanks! |
- WIP Signed off by: Dao McGill <[email protected]>
- annotate.R generates the XML file - query.R calls the query functions, depending on options Note: may have to revisit output format after getting into the fasttext notebook Signed-off-by: Dao McGill <[email protected]>
@carlosparadis I have added exec scripts for annotating and parsing. I have, however, had issues with defining a generic function that can take any XPath query as an argument. The generic solution would have to accommodate distinct xml structures with differing hierarchical relationships. I had to make some changes for each query function. For example, certain queries required that I define and pass the namespace, while others worked without (the preexisting functions did not use require this). Do you think I should continue to pursue this? |
Are you saying you can't use this function? Lines 327 to 341 in 7e7afba
I expect the other functions to be more specific: Line 356 in 7e7afba
and Line 399 in 7e7afba
Have their own code logic. I do not expect them to reuse each other. The only reused function is Let me know which you are referring a defining a generic function. Also, your issue specification should be updated to reflect the planned function signatures. That will help disambiguate. |
@carlosparadis I understand that query_src_text is the reusable generic function meant to handle the execution of XPath queries. I can have add a way to call that to the exec script. This will result in an unstructured string representation of the query passed in. Does this sound right to you? |
Signed-off-by: Dao McGill <[email protected]>
- Renamed query.R to src_content_parser.R - Edited description - Added descriptions for options - Changed output path slightly - Added a temp config file for easy testing for fasttext issue NOTE: current output_path is a temporary solution that is useful for me right now. This will be fixed pre-merge. Signed-off-by: Dao McGill <[email protected]>
Signed-off-by: Dao McGill <[email protected]>
I just noticed this last week message now. I am assuming you clarified this on call! |
Signed-off-by: Dao McGill <[email protected]>
Signed-off-by: Dao McGill <[email protected]>
Signed-off-by: Dao McGill <[email protected]>
Signed-off-by: Dao McGill <[email protected]>
Signed-off-by: Dao McGill <[email protected]>
Signed-off-by: Dao McGill <[email protected]>
Purpose
This issue is an extension of issue #313. The purpose here is to create configurable /exec scripts that make data tables available externally. The new scripts will add usability to the syntax extraction process by providing a usable way to perform source code annotations and XML querying.
Process
New Scripts
Scripts for running the syntax extractor using existing functions in R/src.R. The functionality for this is split into two parts:
Task List
The text was updated successfully, but these errors were encountered: