Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to SailfishOS' new (by v4.2.0) sharing API #83

Open
Olf0 opened this issue Mar 25, 2024 · 0 comments
Open

Adapt to SailfishOS' new (by v4.2.0) sharing API #83

Olf0 opened this issue Mar 25, 2024 · 0 comments
Labels
bug Something isn't working feature request feature requests, suggestions, ideas etc. help wanted Extra attention is needed

Comments

@Olf0
Copy link
Collaborator

Olf0 commented Mar 25, 2024

SailfishOS 4.2.0 uses a new sharing API and omits the old one, hence currently "sharing" with FileCase is defunct on SailfishOS ≥ 4.2.0.

This code change in Storeman can be used as a template: storeman-developers/harbour-storeman@7196fc2

Edit: An even better template seems to be monich/sailfish-qrshare@102c5b4

But in contrast to Storeman a single codebase should be retained, hence the two code paths for sailfish-version < 4.2.0 and sailfish-version ≥ 4.2.0 ought to be e.g. conditionally compiled by preprocessor statements (see e.g. this construct in the SailfishOS:Chum GUI app as a starting point) etc.

P.S.: This is also one part of issue #84 (i.e. splitting PR #60 and adding backward-compatibility to each of its parts).

@Olf0 Olf0 added bug Something isn't working help wanted Extra attention is needed feature request feature requests, suggestions, ideas etc. labels Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature request feature requests, suggestions, ideas etc. help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant