Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to nvd3/nvd3 #26

Open
nomego opened this issue Mar 12, 2019 · 1 comment
Open

Switch to nvd3/nvd3 #26

nomego opened this issue Mar 12, 2019 · 1 comment

Comments

@nomego
Copy link
Contributor

nomego commented Mar 12, 2019

Currently these elements use https://github.com/novus/nvd3 which uses D3v3.
Should switch to https://github.com/nvd3/nvd3 which uses D3v4.

Although this is also old since D3v5 is out..
@saeidzebardast
Copy link
Owner

As you mentioned, nvd3 is using the old D3 version. I prefer to switch when nvd3 starts using d3 v5. However, feel free to open a PR for using nvd3/nvd3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saeidzebardast @nomego