Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI to ensure script is always tested and working #202

Open
3 tasks
agilgur5 opened this issue Dec 21, 2024 · 2 comments
Open
3 tasks

Add CI to ensure script is always tested and working #202

agilgur5 opened this issue Dec 21, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@agilgur5
Copy link
Contributor

agilgur5 commented Dec 21, 2024

Motivation

It would be great to add Continuous Integration (CI) to the repo to ensure the script and all PRs to it are tested and confirmed working. GitHub Actions would be the easiest/most straightforward way to do that on GH.

I'm not sure if the entire script would be possible to test/compatible with GitHub Actions, but if you can run a SteamOS VM, I would think most, if not all, would work.

Alternatively, could test portions of the script (would need to split some things up) on GHA.

This would also fulfill the OpenSSF Scorecard Check for "CI-Tests"

Implementation Details

  1. MVP would be to just ensure the script exits with a zero exit code and no errors
  2. Could further add some tests against the filesystem or certain commands with bats or similar tools
  3. Could have a matrix to test compatibility against different SteamOS versions or versions of other used code
@agilgur5 agilgur5 changed the title Add Continuous Integration (CI) to ensure script is always tested and working Add CI to ensure script is always tested and working Dec 21, 2024
@agilgur5
Copy link
Contributor Author

agilgur5 commented Dec 21, 2024

but if you can run a SteamOS VM

I don't think this is possible if using GitHub hosted runners; only Ubuntu VMs are supported.

But could run SteamOS as a container via a GHA container job.

Might need specific permissions to be able to run Waydroid in a container (DinD-style)

@agilgur5
Copy link
Contributor Author

agilgur5 commented Jan 27, 2025

SteamOS as a container

holo-docker (from the Decky Loader folks) seems like it could be a better option than docker-steamos as it uses the image direct from Steam/Valve and so would have better dev/prod parity (compared to a more reverse-engineered Arch -> SteamOS image)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants