Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with class date in edit command #1

Open
ryanlml opened this issue Oct 28, 2022 · 0 comments
Open

Issue with class date in edit command #1

ryanlml opened this issue Oct 28, 2022 · 0 comments

Comments

@ryanlml
Copy link
Owner

ryanlml commented Oct 28, 2022

edit 1 dt/2022-10-28 1600-0000 does not give any error, which is fine, I assume that this means the class date starts at 4pm on 28th Oct and ends at 12am 29th Oct.

However, edit 1 dt/2022-10-27 1600-0000 changes the class date that starts at 4pm on 27th Oct and ends at 12am 28th Oct. Since the time "spills over" to the 28th of Oct, I expected that the person shows up in the schedule list for 28 Oct, but it is not there.
Screenshot 2022-10-28 at 4.28.03 PM.png

As a solution perhaps don't allow class dates to end at 0000. If that is input by the user I suggest parsing 0000 as 2359. In this case 1600-2359 is unambiguous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant