There are some issues on SurveyListAdapter

[hoangnguyen92dn]

• I am curious why do you concatenate the description for the text view description? 🤔
  

  survey-exam/app/src/main/java/com/example/nimblesurveys/survey/SurveyListAdapter.kt

  Line 34 in 3ae3ac7

  binding.tvSurveyDescription.text = survey.description + survey.description + survey.description

• By adding l in the adapter, we should avoid modifying the model inside the adapter in my opinion, it could be handled in the mapping step instead.
  

  survey-exam/app/src/main/java/com/example/nimblesurveys/survey/SurveyListAdapter.kt

  Line 37 in 3ae3ac7

  .load("${survey.coverImageUrl}l")

[ryan-conway]

I am curious why do you concatenate the description for the text view description? 🤔

This is an error on my part when testing long survey descriptions, this should be removed asap

By adding l in the adapter, we should avoid modifying the model inside the adapter in my opinion, it could be handled in the mapping step instead.

Noted on this, will adjust

[ryan-conway]

Removed description concatenation and created a new class to hold survey list item data in PR #20

[hoangnguyen92dn]

@ryan-conway I see you updated to use FragmentStateAdapter to show the list of surveys instead of RecyclerView.Adapter with the ViewHolder, could you please share your idea why did you change your mind? 🤔 And I spotted the update outside of the PR #20

[ryan-conway]

@hoangnguyen92dn In order to fix the issue with the page indicator dots, I decided to change to a FragmentStateAdapter so that we can make use of a TabLayout with a dot-style tab with its support for sliding tabs so they do not draw off screen. This seemed quicker to implement than with a Decorator as I am more familiar with this solution