Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage improvement #13

Open
2 tasks
hoangnguyen92dn opened this issue Nov 25, 2021 · 1 comment
Open
2 tasks

Code coverage improvement #13

hoangnguyen92dn opened this issue Nov 25, 2021 · 1 comment

Comments

@hoangnguyen92dn
Copy link

  • It's great to see that you've included a few unit tests 👍  Could we increase the unit test coverage to cover most of the layers of application? It would be great to add a few instrumentation tests to the app as well.

  • Would it be possible to set private access for those constants?

    const val EMAIL = "[email protected]"
    const val PASSWORD = "password"
    const val ACCESS_TOKEN = "accesstoken"
    const val REFRESH_TOKEN = "refreshtoken"
    const val TOKEN_TYPE = "Bearer"
    const val EXPIRY = 7200L
    const val CREATED_AT = 1597169495L

@ryan-conway
Copy link
Owner

@hoangnguyen92dn noted on these, the constants should definitely be private

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants