There are some issues on the UI part

[hoangnguyen92dn]

Hi @ryan-conway, I would like to share with you the list of issues I spotted out as below, my review is based on your last update therefore you might aware of some issues already.

• Login screen

  • These EditText to input username and password do not match the design on Figma, the text color on those fields is different from the design, and the corner radius as well.
  • fragment_login.xml: Unused com.google.android.material.textfield.TextInputLayout, I think we don't to use it because the EditText doesn't need to show the label on top once use entered, please correct me if I am missing something here.
  • Optional: With the better UX, the input keyboard should not be shown once the Login button clicked

• Home screen

  • The indicator doesn't match the design. And the indicator is over screen width when the list of indicators doesn't fit the screen width.

• Support for landscape orientation. Could we have the app support landscape orientation as well, please?

[ryan-conway]

Updated the login screen and the tab indicators in PR #22
Landscape support to follow

[hoangnguyen92dn]

@ryan-conway I am still curious about the TextInputLayout element on the fragment_login.xml 🤔 Any reason why do we still need to use it rather than EditText?

survey-exam/app/src/main/res/layout/fragment_login.xml

Lines 52 to 71 in 9b8b6c1

	<com.google.android.material.textfield.TextInputLayout
	android:id="@+id/tilUsername"
	style="@style/TextField"
	android:layout_width="match_parent"
	android:layout_height="wrap_content"
	android:layout_margin="16dp"
	app:hintEnabled="false"
	app:layout_constraintBottom_toTopOf="@id/tilPassword">
	<com.google.android.material.textfield.TextInputEditText
	android:id="@+id/etUsername"
	android:layout_width="match_parent"
	android:layout_height="wrap_content"
	android:hint="@string/email"
	android:imeOptions="actionNext"
	android:maxLines="1"
	android:inputType="text"
	android:textColor="@color/white"
	android:textColorHint="@color/white_tint" />
	</com.google.android.material.textfield.TextInputLayout>

[ryan-conway]

@hoangnguyen92dn I decided to wrap it in a TextInputLayout so that we can take more advantage of material theming, specifically the ShapeAppearance properties defined in styles.xml