Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greeting and starting the reviewing process 👋 #1

Open
hoangnguyen92dn opened this issue Nov 24, 2021 · 7 comments
Open

Greeting and starting the reviewing process 👋 #1

hoangnguyen92dn opened this issue Nov 24, 2021 · 7 comments

Comments

@hoangnguyen92dn
Copy link

Hello Ryan,

Nice to e-meet you 👋 and thanks for your effort on this submission. My name is Huey - an Android Developer at Nimble and I would like to conduct the feedback via Issue tickets regarding your performance here.

Keep in mind, this is a bidirectional process, so we would love to hear back from you as well, so please don’t hesitate to raise your question/correction in case we missed anything.

If we’re aligned on any issue here and you’d like to correct them, please go ahead and open a Pull Request per fix, merge it when you feel confident and we will follow up on those fixes 😇

I hope you find the process enjoyable. Good luck and happy coding 🤘

@ryan-conway
Copy link
Owner

Hi Huey,

It's nice to meet you too! I'll be on standby if you open any issues here 🙂

Please don't hesitate to let me know if there's anything else you need from me 😇

@hoangnguyen92dn
Copy link
Author

@ryan-conway Good morning 👋

I am done with my first round of code reviewing, please take your time to review the created issues, and don't hesitate to let me know if you need any clarification.

You would resolve the issues in the next couple of days, our HR will follow up with you if you have any questions about the
code review timeline.

Have a nice day ☀️

@hoangnguyen92dn
Copy link
Author

Good morning @ryan-conway 👋

I see you are resolving the submitted issues; just a few remaining issues and the progress is quite good so far. So I want to follow up with you about your plan to finish all the issues then we can finalize the review and evaluate your submission. 😄

Have a nice day ☀️

@ryan-conway
Copy link
Owner

Hi @hoangnguyen92dn

I will try to finish the remaining issues by Tuesday or Wednesday at the latest as I didn't have time to work on them this past weekend 😅
As of now, the remaining issues are:

  • Configure ProGuard and the release build
  • Landscape support
  • Improve code coverage

I'll update again once all issues are addressed 😄

@hoangnguyen92dn
Copy link
Author

@ryan-conway Thanks for the update 😄 As some points, I would suggest you prioritize the remaining issues to update due to time limitations 😄 With the Landscape support, you could mask it as the lowest priority to update 😄

@ryan-conway
Copy link
Owner

@hoangnguyen92dn I just received an email from Talent Acquisition that I have completed the coding challenge and will proceed with the interview process, but there are still open issues here. Shall I continue working on the issue for another round of code review, or has this already been marked for evaluation? 😅

@hoangnguyen92dn
Copy link
Author

@ryan-conway We finalized the evaluation on your code challenge; therefore, you passed this round to processing the next step 😄 Thanks for spending time on the code challenge. Good luck to you on the next step🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants