Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display and filter by tags #92

Open
2 tasks
ohadschn opened this issue Nov 26, 2017 · 4 comments
Open
2 tasks

Display and filter by tags #92

ohadschn opened this issue Nov 26, 2017 · 4 comments

Comments

@ohadschn
Copy link

ohadschn commented Nov 26, 2017

  • Tags are useful when you have several genres in your feed and you want to know which track is which.
  • Being able to filter by tags (preferably using a multi-select dropdown) would be even better!
@ohadschn ohadschn changed the title Display tags Display and filter by tags Nov 26, 2017
@ohadschn
Copy link
Author

ohadschn commented Nov 26, 2017

@rwieruch apologies for the bombardment, I hope I was not too bold. It's just that I was only recently exposed to this site and I really like it (especially since it saved me the effort of building something similar from scratch) and thought I could provide my feedback.

Perhaps I will even tackle some of these myself when I'm done with some other projects I have :)

BTW, there is a similar project here in case you didn't know about it: http://mixyard.com/ (though it is not open source and not actively developed).

@rwieruch
Copy link
Owner

No problem at all! Thanks for opening these Issues. They are great opportunities for newcomers to React to learn something new in an existing project! I will try to advertise these issues on Twitter :) But feel free to solve them yourself too!

@rwieruch
Copy link
Owner

Regarding the issue: I like the idea! I guess the only difficult decision is where to put those extra filters in the UI?

@ohadschn
Copy link
Author

Well one easy way would be to add it to the list of things filtered by the current search box.

It might even be better - say I want to listen to rock mixes, what do I care if it's in the title, tag, or even artist name? They are all very likely to be what I want...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants