Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make script Python 3 compatible #40

Open
goggle opened this issue Mar 2, 2019 · 3 comments
Open

Make script Python 3 compatible #40

goggle opened this issue Mar 2, 2019 · 3 comments

Comments

@goggle
Copy link

goggle commented Mar 2, 2019

I'm currently working on making my Kodi plugins to work with Python 3 (see https://kodi.tv/article/attention-addon-developers-migration-python-3). It is suggested to make all the plugins/scripts compatible with both, Python 2 and Python 3, so that the transition will be smooth.

Currently, script.module.youtube.dl does not work with Python 3. On a Python 3 Kodi test build, I get the following error, when I try to import it:

script.module.youtube.dl/lib/YDStreamExtractor.py", line 418
                                                except YoutubeDLWrapper.youtube_dl.DownloadError, e:
                                                                                                ^
                                            SyntaxError: invalid syntax

There are probably many more lines, where the code is not compatible to Python 3.

Is it planned to release script.module.youtube.dl with Python 3 support?

@sy6sy2
Copy link
Contributor

sy6sy2 commented Oct 1, 2019

Hi @ruuk,
Are you interested on a PR of your add-on for Python 2 AND 3 compatibility?
I am currently working on it.

@ruuk
Copy link
Owner

ruuk commented Oct 1, 2019

A PR would be great!

@sy6sy2
Copy link
Contributor

sy6sy2 commented Feb 9, 2020

A first attempt here #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants