Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SSL_CONF_* #22

Closed
cpu opened this issue May 3, 2024 · 2 comments · Fixed by #33
Closed

Implement SSL_CONF_* #22

cpu opened this issue May 3, 2024 · 2 comments · Fixed by #33
Assignees
@cpu

Comments

@cpu
Copy link
Member

cpu commented May 3, 2024

In #20 we stubbed out the SSL_CONF_* API surface used by Nginx. There's a lot of functionality behind these functions, but it looks like it would be important/reasonable to implement support for the options that have obvious rustls config counterparts.
@cpu cpu self-assigned this Jun 17, 2024
@cpu
Copy link
Member Author

cpu commented Jun 17, 2024

cpu self-assigned this now

I've started to work on this.

This was referenced Jun 21, 2024
Merged
Merged
Merged
Merged
@cpu cpu closed this as completed in #33 Jun 26, 2024
@cpu
Copy link
Member Author

cpu commented Jun 26, 2024

We've implemented support for MinProtocol, MaxProtocol, VerifyMode, Certificate, PrivateKey, VerifyCAPath and VerifyCADir.

There are other commands we could implement once additional infrastructure is in place (see this comment) but for now I think it makes sense to call this "Done Enough ™️" and focus on other areas until there's a reason to re-prioritize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpu cpu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement SSL_CONF_cmd VerifyCAPath and VerifyCADir commands cpu/rustls-openssl-compat
1 participant
@cpu