Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rustls_server_connection_get_server_name to return rustls_str #179

Open
jsha opened this issue Nov 6, 2021 · 0 comments
Open

Change rustls_server_connection_get_server_name to return rustls_str #179

jsha opened this issue Nov 6, 2021 · 0 comments

Comments

@jsha
Copy link
Collaborator

jsha commented Nov 6, 2021

This function was written before we started using rustls_str, and it uses the pattern of writing to a caller-provided buffer. That pattern is quite awkward to use, and rustls_str fits better, so we should use that instead.

Note: #178 (lifetime issues for rustls_connection' getters) may get in the way, but I think the SNI field has the same set-once property we rely on for the other getters.

@cpu cpu changed the title Change rustls_server_connection_get_sni_hostname to return rustls_str Change rustls_server_connection_get_server_name to return rustls_str Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants