Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustls_client_config_builder_new: use the default set if cipher_suites is NULL #163

Open
kevinburke opened this issue Oct 29, 2021 · 0 comments
Open

rustls_client_config_builder_new: use the default set if cipher_suites is NULL #163

kevinburke opened this issue Oct 29, 2021 · 0 comments

Comments

@kevinburke
Copy link
Contributor

I'm having trouble building an array of ciphersuites in C because I don't know C very well and keep being told I'm either discarding the 'const' qualifier from the pointer target type or trying to assign to a constant pointer, and so I keep getting in trouble.

Anyway all I am trying to do is use the default set of cipher suites. It would be nice if rustls_client_config_builder_new could check for null in the cipher_suites argument, and then just use the default set of ciphersuites.
kevinburke added a commit to kevinburke/rustls-ffi that referenced this issue Oct 29, 2021
@kevinburke
client: use DEFAULT_CIPHER_SUITES if none are specified
dd7468c 
I'm having trouble figuring out how to pass in a set of cipher suites
using C, and since all I want is the default set, just make it easier
by providing a reasonable default for the NULL case.

Fixes rustls#163.
@kevinburke kevinburke mentioned this issue Oct 29, 2021
Closed
kevinburke added a commit to kevinburke/rustls-ffi that referenced this issue Oct 30, 2021
@kevinburke
client: use DEFAULT_CIPHER_SUITES if none are specified
7aaf881 
I'm having trouble figuring out how to pass in a set of cipher suites
using C, and since all I want is the default set, just make it easier
by providing a reasonable default for the NULL case.

Fixes rustls#163.
kevinburke added a commit to kevinburke/rustls-ffi that referenced this issue Oct 30, 2021
@kevinburke
client: use DEFAULT_CIPHER_SUITES if none are specified
da12657 
I'm having trouble figuring out how to pass in a set of cipher suites
using C, and since all I want is the default set, just make it easier
by providing a reasonable default for the NULL case.

Fixes rustls#163.
kevinburke added a commit to kevinburke/rustls-ffi that referenced this issue Oct 30, 2021
@kevinburke
client: use DEFAULT_CIPHER_SUITES if none are specified
9877fb4 
I'm having trouble figuring out how to pass in a set of cipher suites
using C, and since all I want is the default set, just make it easier
by providing a reasonable default for the NULL case.

Fixes rustls#163.
kevinburke added a commit to kevinburke/rustls-ffi that referenced this issue Nov 3, 2021
@kevinburke
client: use DEFAULT_CIPHER_SUITES if none are specified
2232e1b 
I'm having trouble figuring out how to pass in a set of cipher suites
using C, and since all I want is the default set, just make it easier
by providing a reasonable default for the NULL case.

Fixes rustls#163.
@kevinburke kevinburke mentioned this issue Nov 3, 2021
Closed
kevinburke added a commit to kevinburke/rustls-ffi that referenced this issue Nov 10, 2021
@kevinburke
client: use DEFAULT_CIPHER_SUITES if none are specified
71840cf 
I'm having trouble figuring out how to pass in a set of cipher suites
using C, and since all I want is the default set, just make it easier
by providing a reasonable default for the NULL case.

Fixes rustls#163.
kevinburke added a commit to kevinburke/rustls-ffi that referenced this issue Nov 10, 2021
@kevinburke
client: use DEFAULT_CIPHER_SUITES if none are specified
b2f3aa2 
I'm having trouble figuring out how to pass in a set of cipher suites
using C, and since all I want is the default set, just make it easier
by providing a reasonable default for the NULL case.

Fixes rustls#163.
kevinburke added a commit to kevinburke/rustls-ffi that referenced this issue Nov 11, 2021
@kevinburke
client: use DEFAULT_CIPHER_SUITES if none are specified
159e6ca 
I'm having trouble figuring out how to pass in a set of cipher suites
using C, and since all I want is the default set, just make it easier
by providing a reasonable default for the NULL case.

Fixes rustls#163.
kevinburke added a commit to kevinburke/rustls-ffi that referenced this issue Nov 15, 2021
@kevinburke
client: use DEFAULT_CIPHER_SUITES if none are specified
15acee5 
I'm having trouble figuring out how to pass in a set of cipher suites
using C, and since all I want is the default set, just make it easier
by providing a reasonable default for the NULL case.

Fixes rustls#163.
kevinburke added a commit to kevinburke/rustls-ffi that referenced this issue Nov 15, 2021
@kevinburke
client: use DEFAULT_CIPHER_SUITES if none are specified
766ff42 
I'm having trouble figuring out how to pass in a set of cipher suites
using C, and since all I want is the default set, just make it easier
by providing a reasonable default for the NULL case.

Fixes rustls#163.
kevinburke added a commit to kevinburke/rustls-ffi that referenced this issue Nov 18, 2021
@kevinburke
client: use DEFAULT_CIPHER_SUITES if none are specified
d828934 
I'm having trouble figuring out how to pass in a set of cipher suites
using C, and since all I want is the default set, just make it easier
by providing a reasonable default for the NULL case.

Fixes rustls#163.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kevinburke