Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't wait for PR approval when PR author is a maintainer #32

Open
cpu opened this issue Jan 9, 2024 · 0 comments
Open

Don't wait for PR approval when PR author is a maintainer #32

cpu opened this issue Jan 9, 2024 · 0 comments

Comments

@cpu
Copy link
Member

cpu commented Jan 9, 2024

An idea from djc in discord:

would be nice if the benchmarking bot knew it doesn't need to wait for approval on PRs where the author is an org maintainer

I think this would be a fairly small lift: we already have the code in place to check when a PR is approved that the approver has an allowed account association. Likely we just need to adjust the event processing for a new PR to skip requiring an approval or a comment if the author has such an association.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant