Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing license files in virtio-vsock crate #298

Open
sandrobonazzola opened this issue Jul 18, 2024 · 4 comments · May be fixed by #318
Open

Missing license files in virtio-vsock crate #298

sandrobonazzola opened this issue Jul 18, 2024 · 4 comments · May be fixed by #318

Comments

@sandrobonazzola
Copy link 

$ rust2rpm -t fedora -a -s virtio-vsock 0.6.0
Downloading virtio-vsock-0.6.0.crate: 100%|██████████████████████████████████████████████████████████████████████████████████████████████| 11.2k/11.2k [00:00<00:00, 249kB/s]
ERROR: No license files were detected. In almost all cases, this is an issue
       with the upstream project that should be reported.

Looks like license files are missing in the cargo package for virto-vsock.
@epilys
Copy link
Member

epilys commented Jul 18, 2024

It seems like they are missing from most if not all crates. In other repositories we symlink to the license files on the root repository directory. Let's do the same thing here.

@stefano-garzarella
Copy link
Member

It seems like they are missing from most if not all crates. In other repositories we symlink to the license files on the root repository directory. Let's do the same thing here.

I was going to write the exact same thing ;-)

@sandrobonazzola
Copy link
Author

Just an update, still there in version 0.8.0.

@stefano-garzarella
Copy link
Member

Just an update, still there in version 0.8.0.

thanks, I'm preparing a PR to fix that.

stefano-garzarella added a commit to stefano-garzarella/vm-virtio that referenced this issue Nov 15, 2024
@stefano-garzarella
Add license files in published crate part of this workspace
2305be1 
Add a symbolic link to license files in each crate we publish
to avoid problems like this:

    $ rust2rpm -t fedora -a -s virtio-vsock 0.6.0
    ERROR: No license files were detected. In almost all cases, this is an issue
           with the upstream project that should be reported.

In the other unpublished crates we have different licenses that we
should resolve before publishing and link the right license files.

Fixes: rust-vmm#298
Signed-off-by: Stefano Garzarella <[email protected]>
@stefano-garzarella stefano-garzarella linked a pull request Nov 15, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add license files in published crate part of this workspace stefano-garzarella/vm-virtio
3 participants
@sandrobonazzola @stefano-garzarella @epilys