Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtio-queue Assertion failure in benches/queue/mod.rs on s390x. #238

Open
plugwash opened this issue May 6, 2023 · 1 comment
Open

Comments

@plugwash
Copy link

plugwash commented May 6, 2023

When running "cargo test --bench main --all-features" for the virtio-queue crate (both the version from crates.io and the latest version from git) on s390x, I get.

Testing single chain (indirect=false)
thread 'main' panicked at 'assertion failed: (left == right)
left: 256,
right: 1', crates/virtio-queue/benches/queue/mod.rs:63:17

I presume this is an endian issue as it is not happening on any of the other architectures we test.

@lauralt
Copy link
Contributor

lauralt commented May 8, 2023

Hi, yeah it is most probably an endianness issue. @slp fixed some of them, see PR, but I am not sure if the benches have been tested as well. We don't have a CI instance for s390x, so the issues on this platform can only be discovered by manual testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants