Relax implicit Sized trait bound for the M parameter of queue trait methods
#152
Assignees
Comments
alexandruag
added a commit
to alexandruag/vm-virtio
that referenced
this issue
Mar 18, 2022
This commit also introduces a relaxation of the trait bound on the generic type parameter `M` for `QueueStateT::avail_idx` (i.e. it no longer has to be `Sized`, as it was implicitly the case before). This change reduces the number of trait bounds that have to be explicitly propagated to the newly introduced methods. We should apply a similar update to the rest of the interface as well (tracked by rust-vmm#152). Signed-off-by: Alexandru Agache <[email protected]>
alexandruag
added a commit
to alexandruag/vm-virtio
that referenced
this issue
Mar 30, 2022
This commit also introduces a relaxation of the trait bound on the generic type parameter `M` for `QueueStateT::avail_idx` (i.e. it no longer has to be `Sized`, as it was implicitly the case before). This change reduces the number of trait bounds that have to be explicitly propagated to the newly introduced methods. We should apply a similar update to the rest of the interface as well (tracked by rust-vmm#152). Signed-off-by: Alexandru Agache <[email protected]>
jiangliu
pushed a commit
that referenced
this issue
Mar 30, 2022
This commit also introduces a relaxation of the trait bound on the generic type parameter `M` for `QueueStateT::avail_idx` (i.e. it no longer has to be `Sized`, as it was implicitly the case before). This change reduces the number of trait bounds that have to be explicitly propagated to the newly introduced methods. We should apply a similar update to the rest of the interface as well (tracked by #152). Signed-off-by: Alexandru Agache <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Traits such as
QueueStateThave many methods which take a genericM: GuestMemorytype parameter, and expect a&Margument. However, due to how implicit trait bounds work in Rust, thoseM: GuestMemoryare actuallyM: GuestMemory + Sized, even ifMdoesn't actually have to beSizedto pass a reference to it. Callers of these methods have to propagate theSizedbound to any type parameters they have standing forM, which makes things unnecessarily restrictive overall. Fix this by explicitly adding a+ ?Sizednegative bound where applicable for theMgeneric type parameter of queue traits.The text was updated successfully, but these errors were encountered: