Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide mask method which returns error #75

Closed
dzmitry-lahoda opened this issue Apr 24, 2024 · 5 comments
Closed

feat: provide mask method which returns error #75

dzmitry-lahoda opened this issue Apr 24, 2024 · 5 comments

Comments

@dzmitry-lahoda
Copy link

so can fail deserialzation if there are bits enabled above mask

needed for binary serde, speficifically #74

@bbaldino
Copy link
Collaborator

Are you running into a need for this in the latest version? After #65 was merged, types should always be in a valid state so there shouldn't be any need to explicitly mask them.

@dzmitry-lahoda
Copy link
Author

hello, seems yes laters.

but I cannot use

uX/src/lib.rs

Line 118 in ab2f367

pub const fn new(value: $type) -> $name {
as panic is not an option in DEserialize. it must error. so will use new logic to produce error

@dzmitry-lahoda
Copy link
Author

Oh, I saw TryFrom non implemented in PR, but it is in master. Seems like backlog is not cleaned on GH. Project feels anandoned.

@bbaldino
Copy link
Collaborator

@dzmitry-lahoda we're going through a bit of a transition as the original maintainer stepped back a bit, but I've recently been trying to do some work here, hoping to spend more time on it.

@dzmitry-lahoda
Copy link
Author

@bbaldino given direct contact opportunity, may you take a look #74 ?

so really did that method by enabling try from for all types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants