Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsha256h2q_u32 (aarch64) and siblings are marked as stable in "current rustc version" #1474

Open
izik1 opened this issue Oct 3, 2023 · 1 comment

Comments

@izik1
Copy link

izik1 commented Oct 3, 2023

https://github.com/rust-lang/stdarch/blob/333e9e9977188d0748327e9b5be0f3f412063174/crates/core_arch/src/arm_shared/crypto.rs

Technically all of these functions are, it's just too much to put in a title.

If this is supposed to be opened against rust-lang/rust, or if they aren't supposed to be stable(? seems to have gotten missed in relnotes at least)*, feel free to point me in the right direction.

I believe it's supposed to be 1.72.0 because that's what I can get on compiler explorer with the following code:

#[cfg(target_arch = "aarch64")]
fn foo() {
    let f = core::arch::aarch64::vsha256h2q_u32;
}

(note that actually calling the function gives the same results but it takes more code to do so.

* = it's stable on stable, that's not gonna change.

@Amanieu
Copy link
Member

Amanieu commented Oct 3, 2023

@rust-lang/release Functions marked as stable in CURRENT_RUSTC_VERSION are still marked that way since the stability attributes didn't get updated in the release process (being in the stdarch submodule instead of the main repo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants