Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap strings and modules sections #1937

Open
gzaripov opened this issue Mar 30, 2024 · 1 comment
Open

Swap strings and modules sections #1937

gzaripov opened this issue Mar 30, 2024 · 1 comment
Labels
A-exercises Area: Exercises C-enhancement Category: Enhancement P-low Priority: Low
Milestone

Comments

@gzaripov
Copy link

gzaripov commented Mar 30, 2024

Hi!

Thank you so much for the wonderful work! I am enjoying learning rust via rustlings. The best learning experience I had.

In the rust book there are firstly modules and then strings. I see that in the rustling repo the order is reversed.

Is it intentional? Do you mind if I make a PR that swaps them? I think that it is nicer to learn when you don't leap between sections.

rustlings/info.toml

Lines 461 to 476 in 9a743f8

[[exercises]]
name = "strings4"
path = "exercises/strings/strings4.rs"
mode = "compile"
hint = "No hints this time ;)"
# MODULES
[[exercises]]
name = "modules1"
path = "exercises/modules/modules1.rs"
mode = "compile"
hint = """
Everything is private in Rust by default-- but there's a keyword we can use
to make something public! The compiler error should point to the thing that
needs to be public."""

image

#1938

@mo8it
Copy link
Contributor

mo8it commented Jul 5, 2024

Closing the PR because of merge conflicts. I will take care of this issue in version 7 (no due date) because it is a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-exercises Area: Exercises C-enhancement Category: Enhancement P-low Priority: Low
Projects
None yet
Development

No branches or pull requests

2 participants